commit 08cf24bc2de1a01bc7294b39c773bc116da906d4
author Daniel Stone <daniels@collabora.com> Mon Jan 16 13:18:21 2017 +0000
committer Daniel Stone <daniels@collabora.com> Mon Jan 16 15:13:45 2017 +0000
tree cd42cf7a044a6efb3684e753225ae284cec6749a
parent 8de91494b32203d079b5b0298ef38b56ef19c2a2

desktop-shell: Support panel-position 'none'

The manpage claims that none is valid, so let's make it so.

Signed-off-by: Daniel Stone <daniels@collabora.com>
Reviewed-by: Quentin Glidic <sardemff7+git@sardemff7.net>

clients/desktop-shell.c

diff --git a/clients/desktop-shell.c b/clients/desktop-shell.c
index bd0032a..b133d86 100644
--- a/clients/desktop-shell.c
+++ b/clients/desktop-shell.c
@@ -1362,25 +1362,24 @@
 {
 	char *position;
 
-	weston_config_section_get_string(s, "panel-position", &position, "top");
-	if (strcmp(position, "top") == 0)
-		desktop->panel_position = WESTON_DESKTOP_SHELL_PANEL_POSITION_TOP;
-	else if (strcmp(position, "bottom") == 0)
-		desktop->panel_position = WESTON_DESKTOP_SHELL_PANEL_POSITION_BOTTOM;
-	else if (strcmp(position, "left") == 0)
-		desktop->panel_position = WESTON_DESKTOP_SHELL_PANEL_POSITION_LEFT;
-	else if (strcmp(position, "right") == 0)
-		desktop->panel_position = WESTON_DESKTOP_SHELL_PANEL_POSITION_RIGHT;
-	else
-		fprintf(stderr, "Wrong panel position: %s\n", position);
-	free(position);
+	desktop->want_panel = 1;
 
-	if (desktop->panel_position == WESTON_DESKTOP_SHELL_PANEL_POSITION_TOP
-	    || desktop->panel_position == WESTON_DESKTOP_SHELL_PANEL_POSITION_BOTTOM
-	    || desktop->panel_position == WESTON_DESKTOP_SHELL_PANEL_POSITION_LEFT
-	    || desktop->panel_position == WESTON_DESKTOP_SHELL_PANEL_POSITION_RIGHT) {
-		desktop->want_panel = 1;
+	weston_config_section_get_string(s, "panel-position", &position, "top");
+	if (strcmp(position, "top") == 0) {
+		desktop->panel_position = WESTON_DESKTOP_SHELL_PANEL_POSITION_TOP;
+	} else if (strcmp(position, "bottom") == 0) {
+		desktop->panel_position = WESTON_DESKTOP_SHELL_PANEL_POSITION_BOTTOM;
+	} else if (strcmp(position, "left") == 0) {
+		desktop->panel_position = WESTON_DESKTOP_SHELL_PANEL_POSITION_LEFT;
+	} else if (strcmp(position, "right") == 0) {
+		desktop->panel_position = WESTON_DESKTOP_SHELL_PANEL_POSITION_RIGHT;
+	} else {
+		/* 'none' is valid here */
+		if (strcmp(position, "none") != 0)
+			fprintf(stderr, "Wrong panel position: %s\n", position);
+		desktop->want_panel = 0;
 	}
+	free(position);
 }
 
 static void