pixman-renderer: add view_transformation_is_translation()
A simple refactoring just to help readability.
Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-By: Derek Foreman <derekf@osg.samsung.com>
Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>
diff --git a/src/pixman-renderer.c b/src/pixman-renderer.c
index 8fd50e3..0b33a2b 100644
--- a/src/pixman-renderer.c
+++ b/src/pixman-renderer.c
@@ -180,6 +180,18 @@
weston_matrix_to_pixman_transform(transform_out, &matrix);
}
+static bool
+view_transformation_is_translation(struct weston_view *view)
+{
+ if (!view->transform.enabled)
+ return true;
+
+ if (view->transform.matrix.type <= WESTON_MATRIX_TRANSFORM_TRANSLATE)
+ return true;
+
+ return false;
+}
+
static void
repaint_region(struct weston_view *ev, struct weston_output *output,
pixman_region32_t *region, pixman_region32_t *surf_region,
@@ -305,9 +317,7 @@
}
/* TODO: Implement repaint_region_complex() using pixman_composite_trapezoids() */
- if (ev->alpha != 1.0 ||
- (ev->transform.enabled &&
- ev->transform.matrix.type != WESTON_MATRIX_TRANSFORM_TRANSLATE)) {
+ if (ev->alpha != 1.0 || !view_transformation_is_translation(ev)) {
repaint_region(ev, output, &repaint, NULL, PIXMAN_OP_OVER);
} else {
/* blended region is whole surface minus opaque region: */