commit 2c3849be91338b0f4d27d264b6a122078f0ffb63
author Philip Withnall <philip.withnall@collabora.co.uk> Mon Nov 25 18:01:45 2013 +0000
committer Kristian Høgsberg <krh@bitplanet.net> Mon Dec 02 11:44:51 2013 -0800
tree 49fa7179c185f043986244cf73c1e5d2e99d68df
parent 648a4dd3ece4e5a2172361fbf82c634be0e17894

shell: Fix a potential NULL pointer dereference

get_shell_surface() may return NULL. Found by scan-build.

src/shell.c

diff --git a/src/shell.c b/src/shell.c
index abed1c7..804a57e 100644
--- a/src/shell.c
+++ b/src/shell.c
@@ -1373,7 +1373,8 @@
 	    workspace_has_only(to, surface))
 		update_workspace(shell, index, from, to);
 	else {
-		if (wl_list_empty(&shsurf->workspace_transform.link))
+		if (shsurf != NULL &&
+		    wl_list_empty(&shsurf->workspace_transform.link))
 			wl_list_insert(&shell->workspaces.anim_sticky_list,
 				       &shsurf->workspace_transform.link);