commit 59987fa1724367c78d9971c5ece22cccc04b2ad7
author Pekka Paalanen <pekka.paalanen@collabora.co.uk> Tue Apr 26 15:50:59 2016 +0300
committer Pekka Paalanen <pekka.paalanen@collabora.co.uk> Fri May 06 14:38:09 2016 +0300
tree b92ee0c56eda0d07a93a1a28c2c61441fcef365d
parent 04baea58fed49c14c65bdf707e847c0673914bc9

compositor: refactor into convert_size_by_transform_scale()

There were two copies of code applying transform and scale to size.
Refactor the code to use just one copy in a new function.

Signed-off-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
Reviewed-by: Bryce Harrington <bryce@osg.samsung.com>

src/compositor.c

diff --git a/src/compositor.c b/src/compositor.c
index 83a5391..ee47a82 100644
--- a/src/compositor.c
+++ b/src/compositor.c
@@ -1725,10 +1725,37 @@
 }
 
 static void
+convert_size_by_transform_scale(int32_t *width_out, int32_t *height_out,
+				int32_t width, int32_t height,
+				uint32_t transform,
+				int32_t scale)
+{
+	assert(scale > 0);
+
+	switch (transform) {
+	case WL_OUTPUT_TRANSFORM_NORMAL:
+	case WL_OUTPUT_TRANSFORM_180:
+	case WL_OUTPUT_TRANSFORM_FLIPPED:
+	case WL_OUTPUT_TRANSFORM_FLIPPED_180:
+		*width_out = width / scale;
+		*height_out = height / scale;
+		break;
+	case WL_OUTPUT_TRANSFORM_90:
+	case WL_OUTPUT_TRANSFORM_270:
+	case WL_OUTPUT_TRANSFORM_FLIPPED_90:
+	case WL_OUTPUT_TRANSFORM_FLIPPED_270:
+		*width_out = height / scale;
+		*height_out = width / scale;
+		break;
+	default:
+		assert(0 && "invalid transform");
+	}
+}
+
+static void
 weston_surface_calculate_size_from_buffer(struct weston_surface *surface)
 {
 	struct weston_buffer_viewport *vp = &surface->buffer_viewport;
-	int32_t width, height;
 
 	if (!surface->buffer_ref.buffer) {
 		surface->width_from_buffer = 0;
@@ -1736,22 +1763,12 @@
 		return;
 	}
 
-	switch (vp->buffer.transform) {
-	case WL_OUTPUT_TRANSFORM_90:
-	case WL_OUTPUT_TRANSFORM_270:
-	case WL_OUTPUT_TRANSFORM_FLIPPED_90:
-	case WL_OUTPUT_TRANSFORM_FLIPPED_270:
-		width = surface->buffer_ref.buffer->height / vp->buffer.scale;
-		height = surface->buffer_ref.buffer->width / vp->buffer.scale;
-		break;
-	default:
-		width = surface->buffer_ref.buffer->width / vp->buffer.scale;
-		height = surface->buffer_ref.buffer->height / vp->buffer.scale;
-		break;
-	}
-
-	surface->width_from_buffer = width;
-	surface->height_from_buffer = height;
+	convert_size_by_transform_scale(&surface->width_from_buffer,
+					&surface->height_from_buffer,
+					surface->buffer_ref.buffer->width,
+					surface->buffer_ref.buffer->height,
+					vp->buffer.transform,
+					vp->buffer.scale);
 }
 
 static void
@@ -4168,30 +4185,13 @@
 weston_output_transform_scale_init(struct weston_output *output, uint32_t transform, uint32_t scale)
 {
 	output->transform = transform;
+	output->native_scale = scale;
+	output->current_scale = scale;
 
-	switch (transform) {
-	case WL_OUTPUT_TRANSFORM_90:
-	case WL_OUTPUT_TRANSFORM_270:
-	case WL_OUTPUT_TRANSFORM_FLIPPED_90:
-	case WL_OUTPUT_TRANSFORM_FLIPPED_270:
-		/* Swap width and height */
-		output->width = output->current_mode->height;
-		output->height = output->current_mode->width;
-		break;
-	case WL_OUTPUT_TRANSFORM_NORMAL:
-	case WL_OUTPUT_TRANSFORM_180:
-	case WL_OUTPUT_TRANSFORM_FLIPPED:
-	case WL_OUTPUT_TRANSFORM_FLIPPED_180:
-		output->width = output->current_mode->width;
-		output->height = output->current_mode->height;
-		break;
-	default:
-		break;
-	}
-
-	output->native_scale = output->current_scale = scale;
-	output->width /= scale;
-	output->height /= scale;
+	convert_size_by_transform_scale(&output->width, &output->height,
+					output->current_mode->width,
+					output->current_mode->height,
+					transform, scale);
 }
 
 static void