commit a2e20c369bf7cfed45eaeb0dd1fcca62526c1797
author Kristian Høgsberg <krh@bitplanet.net> Wed Oct 09 13:48:09 2013 -0700
committer Kristian Høgsberg <krh@bitplanet.net> Thu Oct 10 16:50:18 2013 -0700
tree 7f217f786e65f3289ca5edff3d0846190178aed7
parent 3b7d841b7e3107d720324444a117905e04925500

vaapi-recorder: Don't leak fd on thread error path

If we successfully open the file but fail to create the thread we
leak the fd.

src/vaapi-recorder.c

diff --git a/src/vaapi-recorder.c b/src/vaapi-recorder.c
index 84848e4..4131407 100644
--- a/src/vaapi-recorder.c
+++ b/src/vaapi-recorder.c
@@ -944,12 +944,11 @@
 	r->height = height;
 	r->drm_fd = drm_fd;
 
-	flags = O_WRONLY | O_CREAT | O_TRUNC | O_CLOEXEC;
-	r->output_fd = open(filename, flags, 0644);
-
 	if (setup_worker_thread(r) < 0)
 		goto err_free;
 
+	flags = O_WRONLY | O_CREAT | O_TRUNC | O_CLOEXEC;
+	r->output_fd = open(filename, flags, 0644);
 	if (r->output_fd < 0)
 		goto err_thread;