commit b2d79d504efaab06088a011bf25c9affe1dbc3d1
author Bryce Harrington <bryce@osg.samsung.com> Thu Jul 09 21:30:16 2015 -0700
committer Bryce Harrington <bryce@osg.samsung.com> Fri Jul 10 18:08:26 2015 -0700
tree 7f7ec9ff26fb0614a3659f3d3534c5f98613c981
parent cf7d95a6880c820630a6810895be6acaf9ab1e6c

xwayland: Check return of xcb_get_property_reply() before deref

The man pages indicate this routine can return NULL on certain error
conditions.

Suggested by Marek Chalupa

Signed-off-by: Bryce Harrington <bryce@osg.samsung.com>
Reviewed-by: Marek Chalupa <mchqwerty@gmail.com>

xwayland/selection.c

diff --git a/xwayland/selection.c b/xwayland/selection.c
index 451b915..2f60c0e 100644
--- a/xwayland/selection.c
+++ b/xwayland/selection.c
@@ -111,6 +111,8 @@
 				  0x1fffffff /* length */);
 
 	reply = xcb_get_property_reply(wm->conn, cookie, NULL);
+	if (reply == NULL)
+		return;
 
 	dump_property(wm, wm->atom.wl_selection, reply);
 
@@ -184,6 +186,8 @@
 				  4096 /* length */);
 
 	reply = xcb_get_property_reply(wm->conn, cookie, NULL);
+	if (reply == NULL)
+		return;
 
 	dump_property(wm, wm->atom.wl_selection, reply);
 
@@ -236,6 +240,8 @@
 				  0x1fffffff /* length */);
 
 	reply = xcb_get_property_reply(wm->conn, cookie, NULL);
+	if (reply == NULL)
+		return;
 
 	if (reply->type == wm->atom.incr) {
 		dump_property(wm, wm->atom.wl_selection, reply);