desktop-shell: drop shell_client from the head of the surface list on destroy
This prevents a use after free when the surfaces are automatically cleaned
up later, as shell_client's freed node was still in the surface list.
Signed-off-by: Derek Foreman <derekf@osg.samsung.com>
Acked-by: Pekka Paalanen <pekka.paalanen@collabora.co.uk>
diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c
index 487c3e7..05aa340 100644
--- a/desktop-shell/shell.c
+++ b/desktop-shell/shell.c
@@ -5841,6 +5841,13 @@
if (sc->ping_timer)
wl_event_source_remove(sc->ping_timer);
+
+ /* Since we're about to free shell_client, we remove it from the
+ * head of the surface list so we don't use that freed list node
+ * during surface clean up later on.
+ */
+ wl_list_remove(&sc->surface_list);
+
free(sc);
}