commit f2807701d90a6a5fd161f57b0ad4a2a84ec5ec4a
author Kristian Høgsberg <krh@bitplanet.net> Tue Jul 23 11:43:03 2013 -0700
committer Kristian Høgsberg <krh@bitplanet.net> Thu Jul 25 15:58:00 2013 -0700
tree 63d6c92be5f9066b90d04549a88da12d67ff8fdc
parent 636156d5f693ac5b01cec6a2937d2b6cd4237ea9

weston-launch: Switch to regular poll

epoll doesn't provide any convenince here and is just awkward to use.

src/weston-launch.c

diff --git a/src/weston-launch.c b/src/weston-launch.c
index b438e50..8d8a903 100644
--- a/src/weston-launch.c
+++ b/src/weston-launch.c
@@ -26,6 +26,7 @@
 #include <stdlib.h>
 #include <string.h>
 #include <assert.h>
+#include <poll.h>
 #include <errno.h>
 
 #include <error.h>
@@ -36,7 +37,6 @@
 #include <sys/stat.h>
 #include <sys/wait.h>
 #include <sys/socket.h>
-#include <sys/epoll.h>
 #include <sys/signalfd.h>
 #include <signal.h>
 #include <unistd.h>
@@ -68,7 +68,6 @@
 	int sock[2];
 	struct passwd *pw;
 
-	int epollfd;
 	int signalfd;
 
 	pid_t child;
@@ -191,19 +190,11 @@
 static int
 setup_launcher_socket(struct weston_launch *wl)
 {
-	struct epoll_event ev;
-
 	if (socketpair(AF_LOCAL, SOCK_DGRAM, 0, wl->sock) < 0)
 		error(1, errno, "socketpair failed");
 	
 	fcntl(wl->sock[0], F_SETFD, O_CLOEXEC);
 
-	memset(&ev, 0, sizeof ev);
-	ev.events = EPOLLIN;
-	ev.data.fd = wl->sock[0];
-	if (epoll_ctl(wl->epollfd, EPOLL_CTL_ADD, ev.data.fd, &ev) < 0)
-		return -errno;
-
 	return 0;
 }
 
@@ -213,7 +204,6 @@
 	int ret;
 	sigset_t mask;
 	struct sigaction sa;
-	struct epoll_event ev;
 
 	memset(&sa, 0, sizeof sa);
 	sa.sa_handler = SIG_DFL;
@@ -237,12 +227,6 @@
 	if (wl->signalfd < 0)
 		return -errno;
 
-	memset(&ev, 0, sizeof ev);
-	ev.events = EPOLLIN;
-	ev.data.fd = wl->signalfd;
-	if (epoll_ctl(wl->epollfd, EPOLL_CTL_ADD, ev.data.fd, &ev) < 0)
-		return -errno;
-
 	return 0;
 }
 
@@ -413,7 +397,6 @@
 {
 	int err;
 
-	close(wl->epollfd);
 	close(wl->signalfd);
 	close(wl->sock[0]);
 
@@ -656,10 +639,6 @@
 	if (wl.new_user && setup_pam(&wl) < 0)
 		exit(EXIT_FAILURE);
 
-	wl.epollfd = epoll_create1(EPOLL_CLOEXEC);
-	if (wl.epollfd < 0)
-		error(1, errno, "epoll create failed");
-
 	if (setup_launcher_socket(&wl) < 0)
 		exit(EXIT_FAILURE);
 
@@ -680,18 +659,20 @@
 		close(wl.tty);
 
 	while (1) {
-		struct epoll_event ev;
+		struct pollfd fds[2];
 		int n;
 
-		n = epoll_wait(wl.epollfd, &ev, 1, -1);
-		if (n < 0)
-			error(0, errno, "epoll_wait failed");
-		if (n != 1)
-			continue;
+		fds[0].fd = wl.sock[0];
+		fds[0].events = POLLIN;
+		fds[1].fd = wl.signalfd;
+		fds[1].events = POLLIN;
 
-		if (ev.data.fd == wl.sock[0])
+		n = poll(fds, 2, -1);
+		if (n < 0)
+			error(0, errno, "poll failed");
+		if (fds[0].revents & POLLIN)
 			handle_socket_msg(&wl);
-		else if (ev.data.fd == wl.signalfd)
+		if (fds[1].revents)
 			handle_signal(&wl);
 	}