| commit | 1c9ef163a80e03f83d8514461d1a339c3f8bd672 | [log] [tgz] |
|---|---|---|
| author | Jenkins SH <jenkins.sh@amlogic.com> | Fri Dec 27 14:31:49 2024 +0000 |
| committer | Jenkins SH <jenkins.sh@amlogic.com> | Fri Dec 27 14:31:49 2024 +0000 |
| tree | b26635e71d7827d4b90af4e301ca60812d0f8b4f | |
| parent | e1b099727d2f51ea26e9a9526997217709e1bd33 [diff] |
commit 6c749e4d git:core branch:projects/t7 ddr:b6f7a21
Author: Tao Zeng <tao.zeng@amlogic.com>
Date: Mon Sep 2 15:09:14 2024 +0800
Riscure: fix default return value issue [1/1]
PD#RSP-6590
Problem:
Riscure review finding:
In this (and many other functions) the return values are initialized to the
'success' value at the start of the function. If for whatever reason (e.g.
fault injection) the call to mkl_keygen() gets skipped, then the value of
'ret' still fulfills the check and the error is not properly detected,
potentially leading to incorrect initialization.
Solution:
Set default return value of 0 to -1 in drivers;
Verify:
t7
Change-Id: I1736b2d004d18ee405e0c363701e22c37bad0364
Signed-off-by: Tao Zeng <tao.zeng@amlogic.com>
t7 build ok
Change-Id: I2744146003e99f772d19e19dee057624a7dc9bd5
diff --git a/t7/a311d2/bb1st.sto.bin.signed b/t7/a311d2/bb1st.sto.bin.signed index 419e58b..7715fea 100644 --- a/t7/a311d2/bb1st.sto.bin.signed +++ b/t7/a311d2/bb1st.sto.bin.signed Binary files differ
diff --git a/t7/a311d2/bb1st.usb.bin.signed b/t7/a311d2/bb1st.usb.bin.signed index ebb3582..8ddc46f 100644 --- a/t7/a311d2/bb1st.usb.bin.signed +++ b/t7/a311d2/bb1st.usb.bin.signed Binary files differ
diff --git a/t7/a311d2/ddr4/bb1st.sto.bin.bl2-only b/t7/a311d2/ddr4/bb1st.sto.bin.bl2-only index b9c8646..d9c094f 100644 --- a/t7/a311d2/ddr4/bb1st.sto.bin.bl2-only +++ b/t7/a311d2/ddr4/bb1st.sto.bin.bl2-only Binary files differ
diff --git a/t7/a311d2/ddr4/bb1st.sto.bin.signed b/t7/a311d2/ddr4/bb1st.sto.bin.signed index 4de66e5..a8e39c1 100755 --- a/t7/a311d2/ddr4/bb1st.sto.bin.signed +++ b/t7/a311d2/ddr4/bb1st.sto.bin.signed Binary files differ
diff --git a/t7/a311d2/ddr4/bb1st.usb.bin.bl2-only b/t7/a311d2/ddr4/bb1st.usb.bin.bl2-only index e55fc16..542bf76 100644 --- a/t7/a311d2/ddr4/bb1st.usb.bin.bl2-only +++ b/t7/a311d2/ddr4/bb1st.usb.bin.bl2-only Binary files differ
diff --git a/t7/a311d2/ddr4/bb1st.usb.bin.signed b/t7/a311d2/ddr4/bb1st.usb.bin.signed index 66afcad..532dea9 100755 --- a/t7/a311d2/ddr4/bb1st.usb.bin.signed +++ b/t7/a311d2/ddr4/bb1st.usb.bin.signed Binary files differ
diff --git a/t7/a311d2/lpddr4/bb1st.sto.bin.bl2-only b/t7/a311d2/lpddr4/bb1st.sto.bin.bl2-only index 027c976..67838f5 100644 --- a/t7/a311d2/lpddr4/bb1st.sto.bin.bl2-only +++ b/t7/a311d2/lpddr4/bb1st.sto.bin.bl2-only Binary files differ
diff --git a/t7/a311d2/lpddr4/bb1st.sto.bin.signed b/t7/a311d2/lpddr4/bb1st.sto.bin.signed index fd66229..c6648dc 100755 --- a/t7/a311d2/lpddr4/bb1st.sto.bin.signed +++ b/t7/a311d2/lpddr4/bb1st.sto.bin.signed Binary files differ
diff --git a/t7/a311d2/lpddr4/bb1st.usb.bin.bl2-only b/t7/a311d2/lpddr4/bb1st.usb.bin.bl2-only index 615784b..478701e 100644 --- a/t7/a311d2/lpddr4/bb1st.usb.bin.bl2-only +++ b/t7/a311d2/lpddr4/bb1st.usb.bin.bl2-only Binary files differ
diff --git a/t7/a311d2/lpddr4/bb1st.usb.bin.signed b/t7/a311d2/lpddr4/bb1st.usb.bin.signed index b0828b7..0f8b469 100755 --- a/t7/a311d2/lpddr4/bb1st.usb.bin.signed +++ b/t7/a311d2/lpddr4/bb1st.usb.bin.signed Binary files differ
diff --git a/t7/a311d2j/bb1st.sto.bin.signed b/t7/a311d2j/bb1st.sto.bin.signed index a78bc69..0c7dcad 100644 --- a/t7/a311d2j/bb1st.sto.bin.signed +++ b/t7/a311d2j/bb1st.sto.bin.signed Binary files differ
diff --git a/t7/a311d2j/bb1st.usb.bin.signed b/t7/a311d2j/bb1st.usb.bin.signed index 0deb48b..3b8be46 100644 --- a/t7/a311d2j/bb1st.usb.bin.signed +++ b/t7/a311d2j/bb1st.usb.bin.signed Binary files differ
diff --git a/t7/a311d2j/ddr4/bb1st.sto.bin.bl2-only b/t7/a311d2j/ddr4/bb1st.sto.bin.bl2-only index 48eec67..d8fa0d8 100644 --- a/t7/a311d2j/ddr4/bb1st.sto.bin.bl2-only +++ b/t7/a311d2j/ddr4/bb1st.sto.bin.bl2-only Binary files differ
diff --git a/t7/a311d2j/ddr4/bb1st.sto.bin.signed b/t7/a311d2j/ddr4/bb1st.sto.bin.signed index bc53e5f..97fff0f 100644 --- a/t7/a311d2j/ddr4/bb1st.sto.bin.signed +++ b/t7/a311d2j/ddr4/bb1st.sto.bin.signed Binary files differ
diff --git a/t7/a311d2j/ddr4/bb1st.usb.bin.bl2-only b/t7/a311d2j/ddr4/bb1st.usb.bin.bl2-only index db3a8a8..07e9f2a 100644 --- a/t7/a311d2j/ddr4/bb1st.usb.bin.bl2-only +++ b/t7/a311d2j/ddr4/bb1st.usb.bin.bl2-only Binary files differ
diff --git a/t7/a311d2j/ddr4/bb1st.usb.bin.signed b/t7/a311d2j/ddr4/bb1st.usb.bin.signed index 0e36c37..0ef7766 100644 --- a/t7/a311d2j/ddr4/bb1st.usb.bin.signed +++ b/t7/a311d2j/ddr4/bb1st.usb.bin.signed Binary files differ
diff --git a/t7/a311d2j/lpddr4/bb1st.sto.bin.bl2-only b/t7/a311d2j/lpddr4/bb1st.sto.bin.bl2-only index a638905..c9fed86 100644 --- a/t7/a311d2j/lpddr4/bb1st.sto.bin.bl2-only +++ b/t7/a311d2j/lpddr4/bb1st.sto.bin.bl2-only Binary files differ
diff --git a/t7/a311d2j/lpddr4/bb1st.sto.bin.signed b/t7/a311d2j/lpddr4/bb1st.sto.bin.signed index 993295c..73c9c17 100644 --- a/t7/a311d2j/lpddr4/bb1st.sto.bin.signed +++ b/t7/a311d2j/lpddr4/bb1st.sto.bin.signed Binary files differ
diff --git a/t7/a311d2j/lpddr4/bb1st.usb.bin.bl2-only b/t7/a311d2j/lpddr4/bb1st.usb.bin.bl2-only index e73d410..cfade90 100644 --- a/t7/a311d2j/lpddr4/bb1st.usb.bin.bl2-only +++ b/t7/a311d2j/lpddr4/bb1st.usb.bin.bl2-only Binary files differ
diff --git a/t7/a311d2j/lpddr4/bb1st.usb.bin.signed b/t7/a311d2j/lpddr4/bb1st.usb.bin.signed index 17e1747..69428bf 100644 --- a/t7/a311d2j/lpddr4/bb1st.usb.bin.signed +++ b/t7/a311d2j/lpddr4/bb1st.usb.bin.signed Binary files differ
diff --git a/t7/pop1/bb1st.sto.bin.signed b/t7/pop1/bb1st.sto.bin.signed index 79b074c..f94124e 100644 --- a/t7/pop1/bb1st.sto.bin.signed +++ b/t7/pop1/bb1st.sto.bin.signed Binary files differ
diff --git a/t7/pop1/bb1st.usb.bin.signed b/t7/pop1/bb1st.usb.bin.signed index fa70516..a90ec21 100644 --- a/t7/pop1/bb1st.usb.bin.signed +++ b/t7/pop1/bb1st.usb.bin.signed Binary files differ
diff --git a/t7/pop1/ddr4/bb1st.sto.bin.bl2-only b/t7/pop1/ddr4/bb1st.sto.bin.bl2-only index 9c24de3..7de0505 100644 --- a/t7/pop1/ddr4/bb1st.sto.bin.bl2-only +++ b/t7/pop1/ddr4/bb1st.sto.bin.bl2-only Binary files differ
diff --git a/t7/pop1/ddr4/bb1st.sto.bin.signed b/t7/pop1/ddr4/bb1st.sto.bin.signed index 70de2d8..4fe79f5 100755 --- a/t7/pop1/ddr4/bb1st.sto.bin.signed +++ b/t7/pop1/ddr4/bb1st.sto.bin.signed Binary files differ
diff --git a/t7/pop1/ddr4/bb1st.usb.bin.bl2-only b/t7/pop1/ddr4/bb1st.usb.bin.bl2-only index 25343a9..358d76d 100644 --- a/t7/pop1/ddr4/bb1st.usb.bin.bl2-only +++ b/t7/pop1/ddr4/bb1st.usb.bin.bl2-only Binary files differ
diff --git a/t7/pop1/ddr4/bb1st.usb.bin.signed b/t7/pop1/ddr4/bb1st.usb.bin.signed index f6d74ff..343369d 100755 --- a/t7/pop1/ddr4/bb1st.usb.bin.signed +++ b/t7/pop1/ddr4/bb1st.usb.bin.signed Binary files differ
diff --git a/t7/pop1/lpddr4/bb1st.sto.bin.bl2-only b/t7/pop1/lpddr4/bb1st.sto.bin.bl2-only index d023a22..eabc47a 100644 --- a/t7/pop1/lpddr4/bb1st.sto.bin.bl2-only +++ b/t7/pop1/lpddr4/bb1st.sto.bin.bl2-only Binary files differ
diff --git a/t7/pop1/lpddr4/bb1st.sto.bin.signed b/t7/pop1/lpddr4/bb1st.sto.bin.signed index d2298ac..090cbb5 100755 --- a/t7/pop1/lpddr4/bb1st.sto.bin.signed +++ b/t7/pop1/lpddr4/bb1st.sto.bin.signed Binary files differ
diff --git a/t7/pop1/lpddr4/bb1st.usb.bin.bl2-only b/t7/pop1/lpddr4/bb1st.usb.bin.bl2-only index a95d8e8..33d2176 100644 --- a/t7/pop1/lpddr4/bb1st.usb.bin.bl2-only +++ b/t7/pop1/lpddr4/bb1st.usb.bin.bl2-only Binary files differ
diff --git a/t7/pop1/lpddr4/bb1st.usb.bin.signed b/t7/pop1/lpddr4/bb1st.usb.bin.signed index d3b4e79..0a62bc7 100755 --- a/t7/pop1/lpddr4/bb1st.usb.bin.signed +++ b/t7/pop1/lpddr4/bb1st.usb.bin.signed Binary files differ
diff --git a/t7/v918d/bb1st.sto.bin.signed b/t7/v918d/bb1st.sto.bin.signed index 7d07ca5..dcb4c6d 100644 --- a/t7/v918d/bb1st.sto.bin.signed +++ b/t7/v918d/bb1st.sto.bin.signed Binary files differ
diff --git a/t7/v918d/bb1st.usb.bin.signed b/t7/v918d/bb1st.usb.bin.signed index 8c62b37..49fb388 100644 --- a/t7/v918d/bb1st.usb.bin.signed +++ b/t7/v918d/bb1st.usb.bin.signed Binary files differ
diff --git a/t7/v918d/ddr4/bb1st.sto.bin.bl2-only b/t7/v918d/ddr4/bb1st.sto.bin.bl2-only index e2516fa..e24310c 100644 --- a/t7/v918d/ddr4/bb1st.sto.bin.bl2-only +++ b/t7/v918d/ddr4/bb1st.sto.bin.bl2-only Binary files differ
diff --git a/t7/v918d/ddr4/bb1st.sto.bin.signed b/t7/v918d/ddr4/bb1st.sto.bin.signed index 8e90f19..41388ba 100644 --- a/t7/v918d/ddr4/bb1st.sto.bin.signed +++ b/t7/v918d/ddr4/bb1st.sto.bin.signed Binary files differ
diff --git a/t7/v918d/ddr4/bb1st.usb.bin.bl2-only b/t7/v918d/ddr4/bb1st.usb.bin.bl2-only index 2e475ce..ce63313 100644 --- a/t7/v918d/ddr4/bb1st.usb.bin.bl2-only +++ b/t7/v918d/ddr4/bb1st.usb.bin.bl2-only Binary files differ
diff --git a/t7/v918d/ddr4/bb1st.usb.bin.signed b/t7/v918d/ddr4/bb1st.usb.bin.signed index 6ff25e8..1c9fa84 100644 --- a/t7/v918d/ddr4/bb1st.usb.bin.signed +++ b/t7/v918d/ddr4/bb1st.usb.bin.signed Binary files differ
diff --git a/t7/v918d/lpddr4/bb1st.sto.bin.bl2-only b/t7/v918d/lpddr4/bb1st.sto.bin.bl2-only index eea4f72..0665c81 100644 --- a/t7/v918d/lpddr4/bb1st.sto.bin.bl2-only +++ b/t7/v918d/lpddr4/bb1st.sto.bin.bl2-only Binary files differ
diff --git a/t7/v918d/lpddr4/bb1st.sto.bin.signed b/t7/v918d/lpddr4/bb1st.sto.bin.signed index 768afc3..3013826 100644 --- a/t7/v918d/lpddr4/bb1st.sto.bin.signed +++ b/t7/v918d/lpddr4/bb1st.sto.bin.signed Binary files differ
diff --git a/t7/v918d/lpddr4/bb1st.usb.bin.bl2-only b/t7/v918d/lpddr4/bb1st.usb.bin.bl2-only index f4c660f..373ee35 100644 --- a/t7/v918d/lpddr4/bb1st.usb.bin.bl2-only +++ b/t7/v918d/lpddr4/bb1st.usb.bin.bl2-only Binary files differ
diff --git a/t7/v918d/lpddr4/bb1st.usb.bin.signed b/t7/v918d/lpddr4/bb1st.usb.bin.signed index b4aa351..07c1406 100644 --- a/t7/v918d/lpddr4/bb1st.usb.bin.signed +++ b/t7/v918d/lpddr4/bb1st.usb.bin.signed Binary files differ