| commit | 52b328c81fd0d17c59f5ca13d0858a743cce8893 | [log] [tgz] |
|---|---|---|
| author | Jenkins SH <jenkins.sh@amlogic.com> | Fri Dec 27 08:29:38 2024 +0000 |
| committer | Jenkins SH <jenkins.sh@amlogic.com> | Fri Dec 27 08:29:38 2024 +0000 |
| tree | c0ec1a8d4cd62633ef75b2b8c5e6c7063e4fb64a | |
| parent | 5960436c2aea6f02107d5ac31ba359db42736e06 [diff] |
commit 93521024 git:core branch:projects/s5 ddr:b6f7a21
Author: Tao Zeng <tao.zeng@amlogic.com>
Date: Mon Sep 2 15:09:14 2024 +0800
Riscure: fix default return value issue [1/1]
PD#RSP-6590
Problem:
Riscure review finding:
In this (and many other functions) the return values are initialized to the
'success' value at the start of the function. If for whatever reason (e.g.
fault injection) the call to mkl_keygen() gets skipped, then the value of
'ret' still fulfills the check and the error is not properly detected,
potentially leading to incorrect initialization.
Solution:
Set default return value of 0 to -1 in drivers;
Verify:
s5
Change-Id: I1736b2d004d18ee405e0c363701e22c37bad0364
Signed-off-by: Tao Zeng <tao.zeng@amlogic.com>
s5 build ok
Change-Id: I679677f2f9e0c2d31b48ae44955690c2848aa0ff
diff --git a/s5/s928x/bb1st.sto.bin.signed b/s5/s928x/bb1st.sto.bin.signed index 97b7414..d31c8ca 100644 --- a/s5/s928x/bb1st.sto.bin.signed +++ b/s5/s928x/bb1st.sto.bin.signed Binary files differ
diff --git a/s5/s928x/bb1st.usb.bin.signed b/s5/s928x/bb1st.usb.bin.signed index d4d2081..48dfd3d 100644 --- a/s5/s928x/bb1st.usb.bin.signed +++ b/s5/s928x/bb1st.usb.bin.signed Binary files differ
diff --git a/s5/s928xeng/bb1st.sto.bin.signed b/s5/s928xeng/bb1st.sto.bin.signed index a938919..61073ac 100644 --- a/s5/s928xeng/bb1st.sto.bin.signed +++ b/s5/s928xeng/bb1st.sto.bin.signed Binary files differ
diff --git a/s5/s928xeng/bb1st.usb.bin.signed b/s5/s928xeng/bb1st.usb.bin.signed index 82c7d34..44ecd33 100644 --- a/s5/s928xeng/bb1st.usb.bin.signed +++ b/s5/s928xeng/bb1st.usb.bin.signed Binary files differ