| commit | 5aeddd55f1afe2a301006afe46e1751d04510254 | [log] [tgz] |
|---|---|---|
| author | Jenkins SH <jenkins.sh@amlogic.com> | Tue Dec 31 01:15:37 2024 +0000 |
| committer | Jenkins SH <jenkins.sh@amlogic.com> | Tue Dec 31 01:15:37 2024 +0000 |
| tree | 5938d9b7ddbf57fb4a7fdef9587792496ad15f86 | |
| parent | ad65b625f03cb1bf19c33124f73f3fed2e7a7923 [diff] |
commit 61f7ca83 git:core branch:projects/c3 ddr:b6f7a21
Author: Tao Zeng <tao.zeng@amlogic.com>
Date: Mon Sep 2 15:09:14 2024 +0800
Riscure: fix default return value issue [1/1]
PD#RSP-6590
Problem:
Riscure review finding:
In this (and many other functions) the return values are initialized to the
'success' value at the start of the function. If for whatever reason (e.g.
fault injection) the call to mkl_keygen() gets skipped, then the value of
'ret' still fulfills the check and the error is not properly detected,
potentially leading to incorrect initialization.
Solution:
Set default return value of 0 to -1 in drivers;
Verify:
c3
Change-Id: I1736b2d004d18ee405e0c363701e22c37bad0364
Signed-off-by: Tao Zeng <tao.zeng@amlogic.com>
c3 build ok
Change-Id: I55d70adfe7a78ea71f726805290b7b7e89315423
diff --git a/c3/c302x/bb1st.sto.bin.signed b/c3/c302x/bb1st.sto.bin.signed index cbb8188..e5fb0e2 100644 --- a/c3/c302x/bb1st.sto.bin.signed +++ b/c3/c302x/bb1st.sto.bin.signed Binary files differ
diff --git a/c3/c302x/bb1st.usb.bin.signed b/c3/c302x/bb1st.usb.bin.signed index 34c19dc..550b13a 100644 --- a/c3/c302x/bb1st.usb.bin.signed +++ b/c3/c302x/bb1st.usb.bin.signed Binary files differ
diff --git a/c3/c302xs/bb1st.sto.bin.signed b/c3/c302xs/bb1st.sto.bin.signed index cacbaaa..e3a6334 100644 --- a/c3/c302xs/bb1st.sto.bin.signed +++ b/c3/c302xs/bb1st.sto.bin.signed Binary files differ
diff --git a/c3/c302xs/bb1st.usb.bin.signed b/c3/c302xs/bb1st.usb.bin.signed index a4026d7..5279e69 100644 --- a/c3/c302xs/bb1st.usb.bin.signed +++ b/c3/c302xs/bb1st.usb.bin.signed Binary files differ
diff --git a/c3/c308l/bb1st.sto.bin.signed b/c3/c308l/bb1st.sto.bin.signed index c967d77..56bafd6 100644 --- a/c3/c308l/bb1st.sto.bin.signed +++ b/c3/c308l/bb1st.sto.bin.signed Binary files differ
diff --git a/c3/c308l/bb1st.usb.bin.signed b/c3/c308l/bb1st.usb.bin.signed index fc7be4d..26f9f3a 100644 --- a/c3/c308l/bb1st.usb.bin.signed +++ b/c3/c308l/bb1st.usb.bin.signed Binary files differ