commit e72149ad git:core branch:projects/sc2 ddr:b6f7a21
Author: Tao Zeng <tao.zeng@amlogic.com>
Date: Mon Sep 2 15:09:14 2024 +0800
Riscure: fix default return value issue [1/1]
PD#RSP-6590
Problem:
Riscure review finding:
In this (and many other functions) the return values are initialized to the
'success' value at the start of the function. If for whatever reason (e.g.
fault injection) the call to mkl_keygen() gets skipped, then the value of
'ret' still fulfills the check and the error is not properly detected,
potentially leading to incorrect initialization.
Solution:
Set default return value of 0 to -1 in drivers;
Verify:
s5
Change-Id: I1736b2d004d18ee405e0c363701e22c37bad0364
Signed-off-by: Tao Zeng <tao.zeng@amlogic.com>
sc2 build ok
Change-Id: Ib52ac731fda1a62aafa66a26d4164e56b879b88a
120 files changed