commit 61f7ca83 git:core branch:projects/c3 ddr:b6f7a21
Author: Tao Zeng <tao.zeng@amlogic.com>
Date: Mon Sep 2 15:09:14 2024 +0800
Riscure: fix default return value issue [1/1]
PD#RSP-6590
Problem:
Riscure review finding:
In this (and many other functions) the return values are initialized to the
'success' value at the start of the function. If for whatever reason (e.g.
fault injection) the call to mkl_keygen() gets skipped, then the value of
'ret' still fulfills the check and the error is not properly detected,
potentially leading to incorrect initialization.
Solution:
Set default return value of 0 to -1 in drivers;
Verify:
c3
Change-Id: I1736b2d004d18ee405e0c363701e22c37bad0364
Signed-off-by: Tao Zeng <tao.zeng@amlogic.com>
c3 build ok
Change-Id: I55d70adfe7a78ea71f726805290b7b7e89315423
6 files changed