| commit | dbe1117c3d4b7e274b7fe68921047f50aa12e05c | [log] [tgz] |
|---|---|---|
| author | Jenkins SH <jenkins.sh@amlogic.com> | Sat Dec 28 04:22:55 2024 +0000 |
| committer | Jenkins SH <jenkins.sh@amlogic.com> | Sat Dec 28 04:22:55 2024 +0000 |
| tree | 07b56f1d374f2fd02ae997076c5f17dc2dda09bb | |
| parent | cfd33cc477c8e78ff3736de8d2dc9162e5b06a4a [diff] |
commit 6880764a git:core branch:projects/s7 ddr:b6f7a21
Author: Tao Zeng <tao.zeng@amlogic.com>
Date: Mon Sep 2 15:09:14 2024 +0800
Riscure: fix default return value issue [1/1]
PD#RSP-6590
Problem:
Riscure review finding:
In this (and many other functions) the return values are initialized to the
'success' value at the start of the function. If for whatever reason (e.g.
fault injection) the call to mkl_keygen() gets skipped, then the value of
'ret' still fulfills the check and the error is not properly detected,
potentially leading to incorrect initialization.
Solution:
Set default return value of 0 to -1 in drivers;
Verify:
s7
Change-Id: I1736b2d004d18ee405e0c363701e22c37bad0364
Signed-off-by: Tao Zeng <tao.zeng@amlogic.com>
s7 build ok
Change-Id: I5770bed50c5f36a98af6339a4224a9eec054f6b4
diff --git a/s7/s805x3/bb1st.sto.bin.signed b/s7/s805x3/bb1st.sto.bin.signed index 9a8087d..037d64e 100644 --- a/s7/s805x3/bb1st.sto.bin.signed +++ b/s7/s805x3/bb1st.sto.bin.signed Binary files differ
diff --git a/s7/s805x3/bb1st.usb.bin.signed b/s7/s805x3/bb1st.usb.bin.signed index 1d9ada5..95b9db6 100644 --- a/s7/s805x3/bb1st.usb.bin.signed +++ b/s7/s805x3/bb1st.usb.bin.signed Binary files differ
diff --git a/s7/s905y5/bb1st.sto.bin.signed b/s7/s905y5/bb1st.sto.bin.signed index 9cd0f5b..3b5071c 100644 --- a/s7/s905y5/bb1st.sto.bin.signed +++ b/s7/s905y5/bb1st.sto.bin.signed Binary files differ
diff --git a/s7/s905y5/bb1st.usb.bin.signed b/s7/s905y5/bb1st.usb.bin.signed index 932a1c4..37900fa 100644 --- a/s7/s905y5/bb1st.usb.bin.signed +++ b/s7/s905y5/bb1st.usb.bin.signed Binary files differ
diff --git a/s7/s905y5eng/bb1st.sto.bin.signed b/s7/s905y5eng/bb1st.sto.bin.signed index 80b6267..39c17f5 100644 --- a/s7/s905y5eng/bb1st.sto.bin.signed +++ b/s7/s905y5eng/bb1st.sto.bin.signed Binary files differ
diff --git a/s7/s905y5eng/bb1st.usb.bin.signed b/s7/s905y5eng/bb1st.usb.bin.signed index ebc3d1c..e5a450f 100644 --- a/s7/s905y5eng/bb1st.usb.bin.signed +++ b/s7/s905y5eng/bb1st.usb.bin.signed Binary files differ
diff --git a/s7/s905y5r/bb1st.sto.bin.signed b/s7/s905y5r/bb1st.sto.bin.signed index 5b7d6da..c370ffb 100644 --- a/s7/s905y5r/bb1st.sto.bin.signed +++ b/s7/s905y5r/bb1st.sto.bin.signed Binary files differ
diff --git a/s7/s905y5r/bb1st.usb.bin.signed b/s7/s905y5r/bb1st.usb.bin.signed index a503786..9f55249 100644 --- a/s7/s905y5r/bb1st.usb.bin.signed +++ b/s7/s905y5r/bb1st.usb.bin.signed Binary files differ
diff --git a/s7/sdp24430/bb1st.sto.bin.signed b/s7/sdp24430/bb1st.sto.bin.signed index 70de36a..4f277c2 100644 --- a/s7/sdp24430/bb1st.sto.bin.signed +++ b/s7/sdp24430/bb1st.sto.bin.signed Binary files differ
diff --git a/s7/sdp24430/bb1st.usb.bin.signed b/s7/sdp24430/bb1st.usb.bin.signed index a8bcec4..5b90861 100644 --- a/s7/sdp24430/bb1st.usb.bin.signed +++ b/s7/sdp24430/bb1st.usb.bin.signed Binary files differ