| commit | e7e44649e385c45827aa75c08574678a4846a820 | [log] [tgz] |
|---|---|---|
| author | Jenkins SH <jenkins.sh@amlogic.com> | Thu Jan 02 04:24:59 2025 +0000 |
| committer | Jenkins SH <jenkins.sh@amlogic.com> | Thu Jan 02 04:24:59 2025 +0000 |
| tree | 8054552f72847202db1e9fd390a59d4296e05219 | |
| parent | 4a8525a624c152e76699f8a23ee9f3b7f09d94be [diff] |
commit 6305ce69 git:core branch:projects/t3 ddr:b6f7a21
Author: xia.jin <xia.jin@amlogic.com>
Date: Mon Dec 30 06:52:04 2024 +0000
Riscure: fix default return value issue [1/1]
PD#RSP-6590
Problem:
Riscure review finding:
In this (and many other functions) the return values are initialized to the
'success' value at the start of the function. If for whatever reason (e.g.
fault injection) the call to mkl_keygen() gets skipped, then the value of
'ret' still fulfills the check and the error is not properly detected,
potentially leading to incorrect initialization.
Solution:
Set default return value of 0 to -1 in drivers;
Verify:
T3
Change-Id: Ibbda8640a8a1d4136d15ba763ef5930898d8b3b2
Signed-off-by: xia.jin <xia.jin@amlogic.com>
t3 build ok
Change-Id: Ic5dbb5b29f0a439550941e4922c935e0b9fd9db0
diff --git a/t3/t965d4/bb1st.sto.bin.signed b/t3/t965d4/bb1st.sto.bin.signed index d12f71e..37900e5 100755 --- a/t3/t965d4/bb1st.sto.bin.signed +++ b/t3/t965d4/bb1st.sto.bin.signed Binary files differ
diff --git a/t3/t965d4/bb1st.usb.bin.signed b/t3/t965d4/bb1st.usb.bin.signed index be57218..f9d914c 100755 --- a/t3/t965d4/bb1st.usb.bin.signed +++ b/t3/t965d4/bb1st.usb.bin.signed Binary files differ
diff --git a/t3/t982/bb1st.sto.bin.signed b/t3/t982/bb1st.sto.bin.signed index d4832bc..062122d 100755 --- a/t3/t982/bb1st.sto.bin.signed +++ b/t3/t982/bb1st.sto.bin.signed Binary files differ
diff --git a/t3/t982/bb1st.usb.bin.signed b/t3/t982/bb1st.usb.bin.signed index 0299c8e..82c7ce0 100755 --- a/t3/t982/bb1st.usb.bin.signed +++ b/t3/t982/bb1st.usb.bin.signed Binary files differ