commit a22bc85422f814507f355b67a0417359007a81ee
author wentao.ma <wentao.ma@amlogic.com> Thu Oct 13 12:18:06 2022 +0800
committer Wentao MA <wentao.ma@amlogic.com> Thu Oct 13 12:43:40 2022 +0800
tree 7f9145bf7544dd26c536114167477d954048ebba
parent a210e5ed3e36755870902043b0a0a23115d84e44

libdvr: Amazon libdvr coverity issues [1/1]

PD#SWPL-95728

Problem:
Amazon report Coverity errors of libdvr.

Solution:
Fix or suppress INFINITE_LOOP/MISSING_LOCK/NO_EFFECT
/NULL_RETURNS/RESOURCE_LEAK/FORMAT_STRING_INJECTION
/PATH_MANIPULATION errors reported by Coverity.

Verify:
Locally tested OK in AH212 AndroidR environment.

Signed-off-by: Wentao.MA <wentao.ma@amlogic.com>
Change-Id: Ib4bd541f161dc34ec26953c37af828beaac6ddca

src/segment.c

diff --git a/src/segment.c b/src/segment.c
index 22d7c24..80f4c8c 100644
--- a/src/segment.c
+++ b/src/segment.c
@@ -870,9 +870,10 @@
     DVR_RecordSegmentInfo_t *p_info;
 
     p_info = malloc(sizeof(DVR_RecordSegmentInfo_t));
+    DVR_RETURN_IF_FALSE(p_info);
     memset(p_info, 0, sizeof(DVR_RecordSegmentInfo_t));
 
-    list_add_tail(&p_info->head, list);
+    list_add_tail(p_info, list);
 
     /*Load segment id*/
     DVR_RETURN_IF_FALSE(p1);