commit 3e3ab2416841c42df89548cdaf726fd7e2e55a4c
author yuliang.hu <yuliang.hu@amlogic.com> Mon Jul 29 14:52:31 2024 +0800
committer yuliang.hu <yuliang.hu@amlogic.com> Fri Aug 02 12:35:49 2024 +0800
tree 85eea061c66e37872f6b54b0c77bcbe73c75cc81
parent eaa9760a11b30fb0e36f5ca129c79d1dd1cbbee0

audio:  Linux Yocto SDK Coverity Check - aml-amaudioutils. [1/1]

PD#SWPL-172610

Problem:
Linux Yocto SDK Coverity Check - aml-amaudioutils.

Solution:
Fix Coverity Check - aml-amaudioutils.

Verify:
t5w.

Change-Id: I0faeaba9e0f074442d76bb9458f2e16f9fbc4848
Signed-off-by: yuliang.hu <yuliang.hu@amlogic.com>

include/IpcBuffer/IpcBuffer.h

diff --git a/include/IpcBuffer/IpcBuffer.h b/include/IpcBuffer/IpcBuffer.h
index 6ff3fc7..e7042de 100644
--- a/include/IpcBuffer/IpcBuffer.h
+++ b/include/IpcBuffer/IpcBuffer.h
@@ -10,7 +10,7 @@
 {
 public:
   IpcBuffer(const char *name, size_t capacity);
-  ~IpcBuffer();
+  ~IpcBuffer() noexcept(false);
 
   size_t size() const { return size_; }
   size_t capacity() const { return capacity_; }

src/IpcBuffer/IpcBuffer.cpp

diff --git a/src/IpcBuffer/IpcBuffer.cpp b/src/IpcBuffer/IpcBuffer.cpp
index 6dc7868..6bb69d8 100644
--- a/src/IpcBuffer/IpcBuffer.cpp
+++ b/src/IpcBuffer/IpcBuffer.cpp
@@ -22,13 +22,16 @@
   , wr_time_(0)
   , underrun_(0)
   , silence_inserted_(0)
+  ,meta_64_(0)
+  ,meta_32_(0)
 {
   managed_shared_memory *segment = audio_server_shmem::getInstance();
   void *shptr = segment->allocate(capacity);
   handle_ = segment->get_handle_from_address(shptr);
+  std::memset(&meta_ts_, 0, sizeof(meta_ts_));
 }
 
-IpcBuffer::~IpcBuffer()
+IpcBuffer::~IpcBuffer() noexcept (false)
 {
   managed_shared_memory *segment = audio_server_shmem::getInstance();
   uint8_t *base = static_cast<uint8_t *>(segment->get_address_from_handle(handle_));

src/cutils/properties.cpp

diff --git a/src/cutils/properties.cpp b/src/cutils/properties.cpp
index 40bcc6e..ab10858 100644
--- a/src/cutils/properties.cpp
+++ b/src/cutils/properties.cpp
@@ -101,6 +101,7 @@
 }
 
 int32_t property_get_int32(const char *key, int32_t default_value) {
+    /*coverity[integer_overflow]: getenv is under control and will not overflow*/
     return (int32_t)property_get_imax(key, INT32_MIN, INT32_MAX, default_value);
 }
 

src/cutils/threads.cpp

diff --git a/src/cutils/threads.cpp b/src/cutils/threads.cpp
index d3c9af4..9b13a48 100644
--- a/src/cutils/threads.cpp
+++ b/src/cutils/threads.cpp
@@ -50,6 +50,7 @@
 
 void*  thread_store_get( thread_store_t*  store )
 {
+    /*coverity[missing_lock]: Used for conditional judgment, no lock is required*/
     if (!store->has_tls)
         return NULL;