blob: a7eba3005e5ffb11473b274d1f858e9ac79640d5 [file] [log] [blame]
Simon Glass10ea9c02020-12-28 20:35:07 -07001# SPDX-License-Identifier: GPL-2.0+
2# Copyright 2020 Google LLC
3#
4
5"""Tests for the src_scan module
6
7This includes unit tests for scanning of the source code
8"""
9
Simon Glass1a8b4b92021-02-03 06:00:54 -070010import copy
Simon Glass10ea9c02020-12-28 20:35:07 -070011import os
12import shutil
13import tempfile
14import unittest
15from unittest import mock
16
17from dtoc import src_scan
Simon Glass970349a2020-12-28 20:35:08 -070018from patman import test_util
Simon Glass10ea9c02020-12-28 20:35:07 -070019from patman import tools
20
Simon Glassc58662f2021-02-03 06:00:50 -070021OUR_PATH = os.path.dirname(os.path.realpath(__file__))
22
23class FakeNode:
24 """Fake Node object for testing"""
25 def __init__(self):
26 self.name = None
27 self.props = {}
28
29class FakeProp:
30 """Fake Prop object for testing"""
31 def __init__(self):
32 self.name = None
33 self.value = None
34
Simon Glass10ea9c02020-12-28 20:35:07 -070035# This is a test so is allowed to access private things in the module it is
36# testing
37# pylint: disable=W0212
38
39class TestSrcScan(unittest.TestCase):
40 """Tests for src_scan"""
41 @classmethod
42 def setUpClass(cls):
43 tools.PrepareOutputDir(None)
44
45 @classmethod
46 def tearDownClass(cls):
47 tools.FinaliseOutputDir()
48
Simon Glass970349a2020-12-28 20:35:08 -070049 def test_simple(self):
50 """Simple test of scanning drivers"""
51 scan = src_scan.Scanner(None, True, None)
52 scan.scan_drivers()
53 self.assertIn('sandbox_gpio', scan._drivers)
54 self.assertIn('sandbox_gpio_alias', scan._driver_aliases)
55 self.assertEqual('sandbox_gpio',
56 scan._driver_aliases['sandbox_gpio_alias'])
57 self.assertNotIn('sandbox_gpio_alias2', scan._driver_aliases)
58
59 def test_additional(self):
60 """Test with additional drivers to scan"""
Simon Glass10ea9c02020-12-28 20:35:07 -070061 scan = src_scan.Scanner(
Simon Glassdff51a52021-02-03 06:00:56 -070062 None, True,
63 [None, '', 'tools/dtoc/test/dtoc_test_scan_drivers.cxx'])
Simon Glass10ea9c02020-12-28 20:35:07 -070064 scan.scan_drivers()
Simon Glass970349a2020-12-28 20:35:08 -070065 self.assertIn('sandbox_gpio_alias2', scan._driver_aliases)
66 self.assertEqual('sandbox_gpio',
67 scan._driver_aliases['sandbox_gpio_alias2'])
Simon Glass10ea9c02020-12-28 20:35:07 -070068
Simon Glass970349a2020-12-28 20:35:08 -070069 def test_unicode_error(self):
Simon Glass10ea9c02020-12-28 20:35:07 -070070 """Test running dtoc with an invalid unicode file
71
72 To be able to perform this test without adding a weird text file which
73 would produce issues when using checkpatch.pl or patman, generate the
74 file at runtime and then process it.
75 """
76 driver_fn = '/tmp/' + next(tempfile._get_candidate_names())
77 with open(driver_fn, 'wb+') as fout:
78 fout.write(b'\x81')
79
Simon Glass970349a2020-12-28 20:35:08 -070080 scan = src_scan.Scanner(None, True, [driver_fn])
81 with test_util.capture_sys_output() as (stdout, _):
82 scan.scan_drivers()
83 self.assertRegex(stdout.getvalue(),
84 r"Skipping file '.*' due to unicode error\s*")
Simon Glass10ea9c02020-12-28 20:35:07 -070085
86 def test_driver(self):
87 """Test the Driver class"""
Simon Glassc58662f2021-02-03 06:00:50 -070088 i2c = 'I2C_UCLASS'
89 compat = {'rockchip,rk3288-grf': 'ROCKCHIP_SYSCON_GRF',
90 'rockchip,rk3288-srf': None}
91 drv1 = src_scan.Driver('fred', 'fred.c')
92 drv2 = src_scan.Driver('mary', 'mary.c')
93 drv3 = src_scan.Driver('fred', 'fred.c')
94 drv1.uclass_id = i2c
95 drv1.compat = compat
96 drv2.uclass_id = i2c
97 drv2.compat = compat
98 drv3.uclass_id = i2c
99 drv3.compat = compat
100 self.assertEqual(
101 "Driver(name='fred', uclass_id='I2C_UCLASS', "
102 "compat={'rockchip,rk3288-grf': 'ROCKCHIP_SYSCON_GRF', "
103 "'rockchip,rk3288-srf': None}, priv=)", str(drv1))
Simon Glass10ea9c02020-12-28 20:35:07 -0700104 self.assertEqual(drv1, drv3)
105 self.assertNotEqual(drv1, drv2)
106 self.assertNotEqual(drv2, drv3)
107
108 def test_scan_dirs(self):
109 """Test scanning of source directories"""
110 def add_file(fname):
111 pathname = os.path.join(indir, fname)
112 dirname = os.path.dirname(pathname)
113 os.makedirs(dirname, exist_ok=True)
114 tools.WriteFile(pathname, '', binary=False)
115 fname_list.append(pathname)
116
117 try:
118 indir = tempfile.mkdtemp(prefix='dtoc.')
119
120 fname_list = []
121 add_file('fname.c')
Simon Glass36b22202021-02-03 06:00:52 -0700122 add_file('.git/ignoreme.c')
Simon Glass10ea9c02020-12-28 20:35:07 -0700123 add_file('dir/fname2.c')
Simon Glass36b22202021-02-03 06:00:52 -0700124 add_file('build-sandbox/ignoreme2.c')
Simon Glass10ea9c02020-12-28 20:35:07 -0700125
126 # Mock out scan_driver and check that it is called with the
127 # expected files
128 with mock.patch.object(src_scan.Scanner, "scan_driver") as mocked:
129 scan = src_scan.Scanner(indir, True, None)
130 scan.scan_drivers()
131 self.assertEqual(2, len(mocked.mock_calls))
132 self.assertEqual(mock.call(fname_list[0]),
133 mocked.mock_calls[0])
Simon Glass36b22202021-02-03 06:00:52 -0700134 # .git file should be ignored
135 self.assertEqual(mock.call(fname_list[2]),
Simon Glass10ea9c02020-12-28 20:35:07 -0700136 mocked.mock_calls[1])
137 finally:
138 shutil.rmtree(indir)
Simon Glassc58662f2021-02-03 06:00:50 -0700139
140 def test_scan(self):
141 """Test scanning of a driver"""
142 fname = os.path.join(OUR_PATH, '..', '..', 'drivers/i2c/tegra_i2c.c')
143 buff = tools.ReadFile(fname, False)
144 scan = src_scan.Scanner(None, False, None)
145 scan._parse_driver(fname, buff)
146 self.assertIn('i2c_tegra', scan._drivers)
147 drv = scan._drivers['i2c_tegra']
148 self.assertEqual('i2c_tegra', drv.name)
149 self.assertEqual('UCLASS_I2C', drv.uclass_id)
150 self.assertEqual(
151 {'nvidia,tegra114-i2c': 'TYPE_114',
152 'nvidia,tegra20-i2c': 'TYPE_STD',
153 'nvidia,tegra20-i2c-dvc': 'TYPE_DVC'}, drv.compat)
154 self.assertEqual('i2c_bus', drv.priv)
155 self.assertEqual(1, len(scan._drivers))
156
157 def test_normalized_name(self):
158 """Test operation of get_normalized_compat_name()"""
159 prop = FakeProp()
160 prop.name = 'compatible'
161 prop.value = 'rockchip,rk3288-grf'
162 node = FakeNode()
163 node.props = {'compatible': prop}
164 scan = src_scan.Scanner(None, False, None)
165 with test_util.capture_sys_output() as (stdout, _):
166 name, aliases = scan.get_normalized_compat_name(node)
167 self.assertEqual('rockchip_rk3288_grf', name)
168 self.assertEqual([], aliases)
169 self.assertEqual(
170 'WARNING: the driver rockchip_rk3288_grf was not found in the driver list',
171 stdout.getvalue().strip())
172
173 i2c = 'I2C_UCLASS'
174 compat = {'rockchip,rk3288-grf': 'ROCKCHIP_SYSCON_GRF',
175 'rockchip,rk3288-srf': None}
176 drv = src_scan.Driver('fred', 'fred.c')
177 drv.uclass_id = i2c
178 drv.compat = compat
179 scan._drivers['rockchip_rk3288_grf'] = drv
180
181 scan._driver_aliases['rockchip_rk3288_srf'] = 'rockchip_rk3288_grf'
182
183 with test_util.capture_sys_output() as (stdout, _):
184 name, aliases = scan.get_normalized_compat_name(node)
185 self.assertEqual('', stdout.getvalue().strip())
186 self.assertEqual('rockchip_rk3288_grf', name)
187 self.assertEqual([], aliases)
188
189 prop.value = 'rockchip,rk3288-srf'
190 with test_util.capture_sys_output() as (stdout, _):
191 name, aliases = scan.get_normalized_compat_name(node)
192 self.assertEqual('', stdout.getvalue().strip())
193 self.assertEqual('rockchip_rk3288_grf', name)
194 self.assertEqual(['rockchip_rk3288_srf'], aliases)
195
196 def test_scan_errors(self):
197 """Test detection of scanning errors"""
198 buff = '''
199static const struct udevice_id tegra_i2c_ids2[] = {
200 { .compatible = "nvidia,tegra114-i2c", .data = TYPE_114 },
201 { }
202};
203
204U_BOOT_DRIVER(i2c_tegra) = {
205 .name = "i2c_tegra",
206 .id = UCLASS_I2C,
207 .of_match = tegra_i2c_ids,
208};
209'''
210 scan = src_scan.Scanner(None, False, None)
211 with self.assertRaises(ValueError) as exc:
212 scan._parse_driver('file.c', buff)
213 self.assertIn(
214 "file.c: Unknown compatible var 'tegra_i2c_ids' (found: tegra_i2c_ids2)",
215 str(exc.exception))
216
217 def test_of_match(self):
218 """Test detection of of_match_ptr() member"""
219 buff = '''
220static const struct udevice_id tegra_i2c_ids[] = {
221 { .compatible = "nvidia,tegra114-i2c", .data = TYPE_114 },
222 { }
223};
224
225U_BOOT_DRIVER(i2c_tegra) = {
226 .name = "i2c_tegra",
227 .id = UCLASS_I2C,
228 .of_match = of_match_ptr(tegra_i2c_ids),
229};
230'''
231 scan = src_scan.Scanner(None, False, None)
232 scan._parse_driver('file.c', buff)
233 self.assertIn('i2c_tegra', scan._drivers)
234 drv = scan._drivers['i2c_tegra']
235 self.assertEqual('i2c_tegra', drv.name)
Simon Glassc8b19b02021-02-03 06:00:53 -0700236
237 def test_priv(self):
238 """Test collection of struct info from drivers"""
239 buff = '''
240static const struct udevice_id test_ids[] = {
241 { .compatible = "nvidia,tegra114-i2c", .data = TYPE_114 },
242 { }
243};
244
245U_BOOT_DRIVER(testing) = {
246 .name = "testing",
247 .id = UCLASS_I2C,
248 .of_match = test_ids,
249 .priv_auto = sizeof(struct some_priv),
250 .plat_auto = sizeof(struct some_plat),
251 .per_child_auto = sizeof(struct some_cpriv),
252 .per_child_plat_auto = sizeof(struct some_cplat),
253};
254'''
255 scan = src_scan.Scanner(None, False, None)
256 scan._parse_driver('file.c', buff)
257 self.assertIn('testing', scan._drivers)
258 drv = scan._drivers['testing']
259 self.assertEqual('testing', drv.name)
260 self.assertEqual('UCLASS_I2C', drv.uclass_id)
261 self.assertEqual(
262 {'nvidia,tegra114-i2c': 'TYPE_114'}, drv.compat)
263 self.assertEqual('some_priv', drv.priv)
264 self.assertEqual('some_plat', drv.plat)
265 self.assertEqual('some_cpriv', drv.child_priv)
266 self.assertEqual('some_cplat', drv.child_plat)
267 self.assertEqual(1, len(scan._drivers))
Simon Glass1a8b4b92021-02-03 06:00:54 -0700268
269 def test_uclass_scan(self):
270 """Test collection of uclass-driver info"""
271 buff = '''
272UCLASS_DRIVER(i2c) = {
273 .id = UCLASS_I2C,
274 .name = "i2c",
275 .flags = DM_UC_FLAG_SEQ_ALIAS,
276 .priv_auto = sizeof(struct some_priv),
277 .per_device_auto = sizeof(struct per_dev_priv),
278 .per_device_plat_auto = sizeof(struct per_dev_plat),
279 .per_child_auto = sizeof(struct per_child_priv),
280 .per_child_plat_auto = sizeof(struct per_child_plat),
281 .child_post_bind = i2c_child_post_bind,
282};
283
284'''
285 scan = src_scan.Scanner(None, False, None)
286 scan._parse_uclass_driver('file.c', buff)
287 self.assertIn('UCLASS_I2C', scan._uclass)
288 drv = scan._uclass['UCLASS_I2C']
289 self.assertEqual('i2c', drv.name)
290 self.assertEqual('UCLASS_I2C', drv.uclass_id)
291 self.assertEqual('some_priv', drv.priv)
292 self.assertEqual('per_dev_priv', drv.per_dev_priv)
293 self.assertEqual('per_dev_plat', drv.per_dev_plat)
294 self.assertEqual('per_child_priv', drv.per_child_priv)
295 self.assertEqual('per_child_plat', drv.per_child_plat)
296 self.assertEqual(1, len(scan._uclass))
297
298 drv2 = copy.deepcopy(drv)
299 self.assertEqual(drv, drv2)
300 drv2.priv = 'other_priv'
301 self.assertNotEqual(drv, drv2)
302
303 # The hashes only depend on the uclass ID, so should be equal
304 self.assertEqual(drv.__hash__(), drv2.__hash__())
305
306 self.assertEqual("UclassDriver(name='i2c', uclass_id='UCLASS_I2C')",
307 str(drv))
308
309 def test_uclass_scan_errors(self):
310 """Test detection of uclass scanning errors"""
311 buff = '''
312UCLASS_DRIVER(i2c) = {
313 .name = "i2c",
314};
315
316'''
317 scan = src_scan.Scanner(None, False, None)
318 with self.assertRaises(ValueError) as exc:
319 scan._parse_uclass_driver('file.c', buff)
320 self.assertIn("file.c: Cannot parse uclass ID in driver 'i2c'",
321 str(exc.exception))
Simon Glassacf5cb82021-02-03 06:00:55 -0700322
323 def test_struct_scan(self):
324 """Test collection of struct info"""
325 buff = '''
326/* some comment */
327struct some_struct1 {
328 struct i2c_msg *msgs;
329 uint nmsgs;
330};
331'''
332 scan = src_scan.Scanner(None, False, None)
333 scan._basedir = os.path.join(OUR_PATH, '..', '..')
334 scan._parse_structs('arch/arm/include/asm/file.h', buff)
335 self.assertIn('some_struct1', scan._structs)
336 struc = scan._structs['some_struct1']
337 self.assertEqual('some_struct1', struc.name)
338 self.assertEqual('asm/file.h', struc.fname)
339
340 buff = '''
341/* another comment */
342struct another_struct {
343 int speed_hz;
344 int max_transaction_bytes;
345};
346'''
347 scan._parse_structs('include/file2.h', buff)
348 self.assertIn('another_struct', scan._structs)
349 struc = scan._structs['another_struct']
350 self.assertEqual('another_struct', struc.name)
351 self.assertEqual('file2.h', struc.fname)
352
353 self.assertEqual(2, len(scan._structs))
354
355 self.assertEqual("Struct(name='another_struct', fname='file2.h')",
356 str(struc))
357
358 def test_struct_scan_errors(self):
359 """Test scanning a header file with an invalid unicode file"""
360 output = tools.GetOutputFilename('output.h')
361 tools.WriteFile(output, b'struct this is a test \x81 of bad unicode')
362
363 scan = src_scan.Scanner(None, False, None)
364 with test_util.capture_sys_output() as (stdout, _):
365 scan.scan_header(output)
366 self.assertIn('due to unicode error', stdout.getvalue())